Fix inheritdocs for RightShift operator #121598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix incorrect inheritdoc references in right shift operator documentation by changing references from op_LeftShift to op_RightShift. However, the fix is incomplete for the unsigned right shift operators.
Key Issues:
- The
Tensor.op_RightShift.cschanges are correct - arithmetic right shift operators now properly reference their own base documentation instead of left shift. - The
Tensor.op_UnsignedRightShift.cschanges are incorrect - unsigned/logical right shift operators (>>>,>>>=) should referenceop_UnsignedRightShiftandop_UnsignedRightShiftAssignment, not the arithmetic right shift operators (op_RightShift,op_RightShiftAssignment).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tensor.op_RightShift.cs | Correctly fixes inheritdoc references from op_LeftShift to op_RightShift for arithmetic right shift operators (>>, >>=) |
| Tensor.op_UnsignedRightShift.cs | Incorrectly changes references from op_LeftShift to op_RightShift - should reference op_UnsignedRightShift and op_UnsignedRightShiftAssignment instead for unsigned/logical right shift operators (>>>, >>>=) |
.../System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.op_UnsignedRightShift.cs
Outdated
Show resolved
Hide resolved
.../System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.op_UnsignedRightShift.cs
Outdated
Show resolved
Hide resolved
.../System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.op_UnsignedRightShift.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 14, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tannergooding
approved these changes
Nov 14, 2025
Contributor
Author
|
/ba-g documentation only change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.