Avoid array -> span -> array in COSE ToBeSignedBuilder. #121554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ToBeSignedBuilder for hash and pure modes had an Append that accepts a ReadOnlySpan. For .NET Framework and .NET Standard, IncrementalHash and MemoryStream cannot operate on a ReadOnlySpan, so they were getting converted to an array again. There were a number of places where we already had an array though. This change avoids to array to span to array conversation by introducing a new AppendToBeSigned overload that accepts an array with an offset and length, which avoids a ToArray().
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes performance for COSE signing operations by avoiding unnecessary array allocations on .NET Framework and .NET Standard 2.0. The optimization introduces a new AppendToBeSigned overload that accepts array-based parameters (byte[], offset, length) to avoid converting arrays to spans and back to arrays.
- Adds new array-based
AppendToBeSignedoverload to avoid redundant conversions - Updates call sites that already have byte arrays to use the new overload
- Maintains the existing
ReadOnlySpan<byte>overload for stack-allocated buffers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ToBeSignedBuilder.cs | Adds abstract method declaration for array-based AppendToBeSigned overload |
| PureDataToBeSignedBuilder.cs | Implements array-based AppendToBeSigned using MemoryStream.Write |
| HashToBeSignedBuilder.cs | Implements array-based AppendToBeSigned using IncrementalHash.AppendData |
| CoseMessage.cs | Updates three call sites to use the new array-based overload where byte arrays are already available |
This was referenced Nov 12, 2025
Open
bartonjs
approved these changes
Nov 21, 2025
Member
Author
|
/ba-g Android lowmemorykiller. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ToBeSignedBuilder for hash and pure modes had an Append that accepts a ReadOnlySpan. For .NET Framework and .NET Standard, IncrementalHash and MemoryStream cannot operate on a ReadOnlySpan, so they were getting converted to an array again. There were a number of places where we already had an array though.
This change avoids to array to span to array conversation by introducing a new AppendToBeSigned overload that accepts an array with an offset and length, which avoids a ToArray().