Initialize variable in mono_utility_thread_send_sync #121490
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an uninitialized entry->finished variable, that led to early function termination and an incorrect return value.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Nov 10, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By design
donevariable should be set to false and changed to true, when thread finished. But for now,doneis not initialized.doneis used in the loop to check finish status and then as the return value. An uninitialized variable contains a random value. In most cases, this is interpreted as true and leads to early function termination and an incorrect return value.Signed-off-by: Aleksandr Dovydenkov asd@altlinux.org.
Found by Linux Verification Center (linuxtesting.org) with SVACE.