Enable thread abort support in the interpreter #121446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds check for thread abort to the INTOP_SAFEPOINT and also to the code resuming after catch. This makes all the libraries controlled execution tests pass.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds thread abort handling to the interpreter execution loop in the CoreCLR VM. The changes ensure that thread abort requests are properly detected and handled at safe points during interpreter execution.
- Adds abort checking at INTOP_SAFEPOINT instruction to allow cooperative thread abort
- Adds abort handling after exception catch resumption to prevent continuing execution when abort is requested
BrzVlad
reviewed
Nov 7, 2025
BrzVlad
approved these changes
Nov 7, 2025
This was referenced Nov 7, 2025
Open
Member
Author
|
/ba-g the android build timeout is unrelated and happens frequently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds check for thread abort to the INTOP_SAFEPOINT and also to the code resuming after catch. This makes all the libraries controlled execution tests pass.