Limit native AOT to CORINFO_HELP_ALLOC_CONTINUATION
#121444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restricts the use of specialized continuation allocation helpers to non-Native AOT scenarios. Native AOT doesn't require the loader keep-alive mechanism since it lacks a runtime MethodDesc and doesn't have a loader to maintain. The change adds IsTargetAbi(CORINFO_NATIVEAOT_ABI) checks to ensure Native AOT always uses CORINFO_HELP_ALLOC_CONTINUATION instead of the keep-alive variants.
- Added Native AOT ABI checks to skip loader keep-alive logic
- Forces Native AOT to use standard continuation allocation helper
jkotas
reviewed
Nov 7, 2025
jkotas
reviewed
Nov 7, 2025
This was referenced Nov 7, 2025
Open
Native AOT doesn't have a `MethodDesc` at runtime. But that's fine, we don't have a loader to keep alive either.
MichalStrehovsky
force-pushed
the
aotalloccontinuation
branch
from
98c1b23 to
5aecbe1
Compare
jakobbotsch
approved these changes
Nov 10, 2025
3 tasks
Member
Author
|
/ba-g android timeout is dotnet/dnceng#6408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native AOT doesn't have a
MethodDescat runtime. But that's fine, we don't have a loader to keep alive either.Cc @dotnet/ilc-contrib