Fix CertificatePolicy processing. #121395
Open
+120
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong mapping variable was decremented, which could lead to incorrect AnyPolicy depth matching.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in certificate policy validation where the wrong depth counter was being decremented, and adds supporting test infrastructure and a test case to verify the fix.
- Fixes a bug where
inhibitAnyPolicyDepthwas incorrectly decremented instead ofinhibitPolicyMappingDepthin the certificate policy validation logic - Adds a new overload of
MakeTestChain4that allows specifying different extensions for each intermediate certificate independently - Adds a test case to verify policy constraints work correctly with multiple intermediate certificates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| CertificatePolicy.cs | Fixes the bug by changing the decremented variable from inhibitAnyPolicyDepth to inhibitPolicyMappingDepth |
| TestDataGenerator.cs | Adds new overload of MakeTestChain4 to support separate extension parameters for two intermediate certificates |
| DynamicChainTests.cs | Adds test case PolicyConstraints_AnyPolicyInhibited_Success and helper method BuildInhibitAnyPolicy |
src/libraries/System.Security.Cryptography/tests/X509Certificates/TestDataGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/TestDataGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/TestDataGenerator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bartonjs
reviewed
Nov 5, 2025
src/libraries/System.Security.Cryptography/tests/X509Certificates/TestDataGenerator.cs
Show resolved
Hide resolved
This was referenced Nov 6, 2025
Open
bartonjs
reviewed
Nov 6, 2025
src/libraries/System.Security.Cryptography/tests/X509Certificates/TestDataGenerator.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong mapping variable was decremented, which could lead to incorrect AnyPolicy depth matching. This would fail-closed, causing a policy mismatch when it shouldn't.
It should be
inhibitPolicyMappingDepth, notinhibitAnyPolicyDepth. The latter is handled on line 190.