Replace GetPalThreadIdForLogging() with GetOSThreadId() in NativeAOT

[Copilot]

ep_rt_aot_thread_get_id and other call sites were using GetPalThreadIdForLogging(), a method intended only for logging purposes, to retrieve thread IDs for EventPipe, GC, and stress logging functionality.

Changes

• Added Thread::GetOSThreadId() - New public method for proper thread ID access, aligning with CoreCLR's GetOSThreadId64() pattern
• Removed Thread::GetPalThreadIdForLogging() - Deleted the logging-specific method that was being misused for general purposes
• Updated all call sites - Changed ep_rt_aot_thread_get_id(), GCToEEInterface::GetThreadOSThreadId(), and stress logging calls to use GetOSThreadId()

The new GetOSThreadId() method returns m_threadId and provides proper semantics for all thread ID access needs.

// Before
ep_rt_thread_id_t ep_rt_aot_thread_get_id(ep_rt_thread_handle_t thread_handle)
{
    return (ep_rt_thread_id_t)thread_handle->GetPalThreadIdForLogging();
}

// After
ep_rt_thread_id_t ep_rt_aot_thread_get_id(ep_rt_thread_handle_t thread_handle)
{
    return (ep_rt_thread_id_t)thread_handle->GetOSThreadId();
}

• Fixes Consider a better implementation for ep_rt_aot_thread_get_id  #89650

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Consider a better implementation for ep_rt_aot_thread_get_id </issue_title>
<issue_description>Currently, we use GetPalThreadIdForLogging() to get the thread_id, which doesn't look the proper way to get the thread_id.

GetPalThreadIdForLogging() Implementation Details for completeness: EEThreadId classes seems to be doing the right thing to set its first field (pthread_self and GetCurrentThreadId), but doesn't expose a getter (reason for not using for 'normal' use?) GetPalThreadIdForLogging is using this field directly to get the value. See also details of the current_thread_get_id implementation concerns.</issue_description>

Comments on the Issue (you are @copilot in this section)

@ Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas See info in [area-owners.md](https://github.com/dotnet/runtime/blob/main/docs/area-owners.md) if you want to be subscribed.

Issue Details

---

Currently, we use GetPalThreadIdForLogging() to get the thread_id, which doesn't look the proper way to get the thread_id.

GetPalThreadIdForLogging() Implementation Details for completeness: EEThreadId classes seems to be doing the right thing to set its first field (pthread_self and GetCurrentThreadId), but doesn't expose a getter (reason for not using for 'normal' use?) GetPalThreadIdForLogging is using this field directly to get the value. See also details of the current_thread_get_id implementation concerns.

Author:	LakshanF
Assignees:	LakshanF
Labels:	area-NativeAOT-coreclr
Milestone:	9.0.0

• Fixes Consider a better implementation for ep_rt_aot_thread_get_id  #89650

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[jkotas]

/ba-g timeouts

[Copilot]

Pull Request Overview

This PR renames the GetPalThreadIdForLogging method to GetOSThreadId in the NativeAOT runtime to improve naming consistency and clarity.

• The method name is changed from GetPalThreadIdForLogging to GetOSThreadId to better reflect its actual purpose and align with naming conventions used in the CoreCLR VM implementation.
• All call sites across the NativeAOT runtime are updated to use the new method name.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Declaration of the method is renamed from GetPalThreadIdForLogging to GetOSThreadId
src/coreclr/nativeaot/Runtime/thread.cpp	Definition of the method is renamed, and call sites within STRESS_LOG macros are updated
src/coreclr/nativeaot/Runtime/gcenv.ee.cpp	Updated call site in GCToEEInterface::GetThreadOSThreadId to use the renamed method
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Updated call site in ep_rt_aot_thread_get_id to use the renamed method