Don't add the filled in template file to FileWries #121080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSBuild cleans up intermediate file writes from previous builds that weren't also written in the current build after the build but before running the Pack task. This breaks every-other build (as we were actively using the cached copy here if it didn't change). Fixes #121068
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where MSBuild's cleanup of intermediate files was breaking incremental builds. The problem occurred because a generated template file was being tracked as a file write, causing MSBuild to delete it between builds when it wasn't regenerated, breaking every-other-build scenarios.
Key Changes:
- Removed the output tracking of the generated IL targets file to prevent MSBuild from cleaning it up between builds
github-actions
bot
added
the
needs-area-label
janvorli
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSBuild cleans up intermediate file writes from previous builds that weren't also written in the current build after the build but before running the Pack task. This breaks every-other build (as we were actively using the cached copy here if it didn't change).
Fixes #121068