Skip to content

Conversation

@janvorli
Copy link
Member

This change changes __builtin_trap() that we use to break into the debugger on assert to __builtin_debugtrap() on macOS. The former doesn't allow continuing after the assert while the latter does.

This change changes __builtin_trap() that we use to break into the
debugger on assert to __builtin_debugtrap() on macOS. The former doesn't
allow continuing after the assert while the latter does.
Copilot AI review requested due to automatic review settings October 23, 2025 08:45
@janvorli janvorli requested review from BrzVlad and kg as code owners October 23, 2025 08:45
@janvorli janvorli self-assigned this Oct 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables developers to continue execution after hitting an assert in the CoreCLR interpreter when debugging on macOS. The change replaces __builtin_trap() with __builtin_debugtrap() for Apple targets, as the former terminates the process while the latter allows resuming after the debugger breakpoint.

Key Changes:

  • Modified the assertAbort function to use __builtin_debugtrap() on macOS instead of __builtin_trap()

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

@janvorli janvorli merged commit 415b8aa into dotnet:main Oct 23, 2025
98 checks passed
@janvorli janvorli deleted the interpreter-enable-continue-after-assert-macos branch October 23, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants