Consolidate some jit64 tests into less assemblies #120992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where it isn't needed.
…only valuetypes.csproj
…ojects, speeding up builds by a decent amount
… build with BuildAsStandalone on non-Windows)
jkoritzinsky
added
test-enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates multiple JIT64 test projects into fewer assemblies to reduce build overhead. Rather than having each test as a separate project, related tests are grouped together into single assemblies. This effort reduces the project count by 4.3% (removing 455 projects), which helps optimize build times by reducing the cost of building the test tree multiple times and minimizes bit marshalling between jobs.
- Test consolidation via namespace separation instead of separate projects
- Addition of
[OuterLoop]attributes to longer-running tests - Replacement of
GCStressIncompatibleproject properties with[SkipOnCoreClr]attributes - Refactoring of platform-specific test filtering from runtime checks to attributes
Reviewed Changes
Copilot reviewed 300 out of 957 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| box-unbox*.cs | Added file-scoped namespaces and [OuterLoop] attributes to nullable box/unbox tests |
| box-unbox*.csproj | Removed individual project files as tests are now consolidated |
| overflow*.cs | Created individual test files for overflow operations (add, sub, mul, div) with proper namespaces |
| overflow*.csproj | Removed individual project files and created single rtchecks.csproj |
| rtchecks.csproj | New consolidated project file listing all overflow test sources |
| VolatileTest*.cs | Created individual test files for each volatile operator test with namespaces |
| VolatileTest*.csproj | Removed individual projects; tests now consolidated |
| VolatileTest.csproj | New consolidated project for all volatile test sources |
| HugeArray*.cs/csproj | Replaced project-level GCStress settings with test-level [SkipOnCoreClr] attributes |
| HugeField*.cs/csproj | Replaced project-level GCStress settings with test-level attributes |
| hugeexpr1.cs/csproj | Added [OuterLoop] and [SkipOnCoreClr] attributes, removed project properties |
| hugeSimpleExpr1.cs/csproj | Replaced GCStress project properties with [SkipOnCoreClr] attribute |
| ArrayWithThread.cs/csproj | Moved GCStress configuration from project to [SkipOnCoreClr] attribute |
| mcc_interop.ilproj | New consolidated project for all mcc interop IL tests |
| mcc_interop.il | New main entry point that calls all individual mcc test methods |
| mcc_i*.il | Updated namespaces and replaced runtime platform checks with [PlatformSpecific] or [ConditionalFact] attributes |
| mcc_i*.ilproj | Removed individual project files as tests are consolidated |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
am11
reviewed
Oct 24, 2025
am11
reviewed
Oct 24, 2025
am11
reviewed
Oct 24, 2025
am11
reviewed
Oct 24, 2025
am11
reviewed
Oct 24, 2025
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of project files in the src/tests tree by 4.3% (removes 455 projects).
Part of the continuing effort to get us to a point where we don't need separate inner test builds and the cost of building src/tests multiple times is less than the cost of marshalling the bits from different jobs.