Skip to content

Conversation

@janvorli
Copy link
Member

There are missing helpers for 2, 3 and 4 vector64 and vector128 HFA in the interpreter call stubs.

This change implements them.

There are missing helpers for 2, 3 and 4 vector64 and vector128
HFA in the interpreter call stubs.

This change implements them.
@janvorli janvorli added this to the 11.0.0 milestone Oct 22, 2025
@janvorli janvorli self-assigned this Oct 22, 2025
Copilot AI review requested due to automatic review settings October 22, 2025 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing interpreter HFA (Homogeneous Floating-point Aggregate) helpers for ARM64 to support returning 2, 3, and 4 element Vector64 and Vector128 structures. Previously, only single-element vector returns were implemented for the interpreter call stubs.

Key Changes:

  • Added new return type enum values for multi-element Vector64/Vector128 HFAs
  • Implemented corresponding interpreter stub functions and jitted method call helpers
  • Extended return type detection logic to map HFA sizes to appropriate return types

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/coreclr/vm/callstubgenerator.h Adds enum values for 2/3/4 element Vector64 and Vector128 return types
src/coreclr/vm/callstubgenerator.cpp Adds function declarations, switch case handlers, and size-based return type detection for new HFA types
src/coreclr/vm/arm64/asmhelpers.asm Implements ARM64 assembly stubs for new interpreter and jitted method return type handlers (Windows syntax)
src/coreclr/vm/arm64/asmhelpers.S Implements ARM64 assembly stubs for new interpreter and jitted method return type handlers (Unix syntax)

@janvorli janvorli merged commit fbe5d82 into dotnet:main Oct 23, 2025
96 of 98 checks passed
@janvorli janvorli deleted the implement-several-missing-hfa-helpers branch October 23, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants