Remove dead code PathFeatures.cs and assume all path features are available

src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.Windows.cs

@@ -10,12 +10,11 @@ namespace System.Diagnostics.Tests
 {
     public partial class ProcessModuleTests : ProcessTestBase
     {
-        [ConditionalFact(typeof(PathFeatures), nameof(PathFeatures.AreAllLongPathsAvailable))]
+        [Fact]
         public void LongModuleFileNamesAreSupported()
         {
             // To be able to test Long Path support for ProcessModule.FileName we need a .dll that has a path > 260 chars.
-            // Since Long Paths support can be disabled (see the ConditionalFact attribute usage above),
-            // we just copy "LongName.dll" from bin to a temp directory with a long name and load it from there.
+            // We just copy "LongName.dll" from bin to a temp directory with a long name and load it from there.
             // Loading from new path is possible because the type exposed by the assembly is not referenced in any explicit way.
             const string libraryName = "LongPath.dll";
             const int minPathLength = 261;

src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj

@@ -20,8 +20,6 @@
              Link="Common\Microsoft\Win32\TempRegistryKey.cs" />
     <Compile Include="$(CommonPath)System\Text\ValueStringBuilder.cs"
              Link="Common\System\Text\ValueStringBuilder.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs"
-             Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="DelegateSynchronizeInvoke.cs" />
     <Compile Include="FileAssociations.cs" />
     <Compile Include="Helpers.cs" />

src/libraries/System.IO.Compression/tests/System.IO.Compression.Tests.csproj

@@ -29,7 +29,6 @@
     <Compile Include="ZipArchive\zip_ReadTests.cs" />
     <Compile Include="ZipArchive\zip_UpdateTests.cs" />
     <Compile Include="ZipArchive\zip_UpdateTests.Comments.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="$(CommonTestPath)System\IO\CallTrackingStream.cs" Link="Common\System\IO\CallTrackingStream.cs" />
     <Compile Include="$(CommonTestPath)System\IO\Compression\CRC.cs" Link="Common\System\IO\Compression\CRC.cs" />
     <Compile Include="$(CommonTestPath)System\IO\Compression\CompressionStreamTestBase.cs" Link="Common\System\IO\Compression\CompressionStreamTestBase.cs" />

src/libraries/System.IO.Compression/tests/ZipArchive/zip_ManualAndCompatibilityTests.cs

@@ -10,8 +10,6 @@ namespace System.IO.Compression.Tests
 {
     public class zip_ManualAndCompatibilityTests : ZipFileTestBase
     {
-        public static bool IsUsingNewPathNormalization => !PathFeatures.IsUsingLegacyPathNormalization();
-
         public static IEnumerable<object[]> Get_CompatibilityTests_Data()
         {
             foreach (bool async in _bools)
@@ -67,7 +65,7 @@ public static async Task CompatibilityTestsMsFiles(string withTrailing, string w
         /// For example, the file "aa\bb\cc\dd" in a zip created on Unix should be one file "aa\bb\cc\dd" whereas the same file
         /// in a zip created on Windows should be interpreted as the file "dd" underneath three subdirectories.
         /// </summary>
-        [ConditionalTheory(nameof(IsUsingNewPathNormalization))]
+        [Theory]
         [InlineData("backslashes_FromUnix.zip", "aa\\bb\\cc\\dd")]
         [InlineData("backslashes_FromWindows.zip", "dd")]
         [InlineData("WindowsInvalid_FromUnix.zip", "aa<b>d")]

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/CreateDirectory.cs

@@ -152,7 +152,7 @@ public void ValidPathWithTrailingSlash(string component)
             Assert.True(result.Exists);
         }
 
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             MemberData(nameof(ValidPathComponentNames))]
         [PlatformSpecific(TestPlatforms.Windows)]  // trailing slash
         public void ValidExtendedPathWithTrailingSlash(string component)
@@ -239,7 +239,7 @@ public void PathsWithInvalidColons_ThrowIOException_Core(string invalidPath)
             Assert.ThrowsAny<IOException>(() => Create(invalidPath));
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // long directory path succeeds
         public void DirectoryLongerThanMaxPath_Succeeds()
         {
@@ -262,7 +262,7 @@ public void DirectoryLongerThanMaxLongPath_ThrowsPathTooLongException()
             });
         }
 
-        [ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]
         public void DirectoryLongerThanMaxLongPathWithExtendedSyntax_ThrowsException()
         {
@@ -274,7 +274,7 @@ public void DirectoryLongerThanMaxLongPathWithExtendedSyntax_ThrowsException()
                 AssertExtensions.ThrowsAny<PathTooLongException, DirectoryNotFoundException, IOException>(() => Create(path)));
         }
 
-        [ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // long directory path with extended syntax succeeds
         public void ExtendedDirectoryLongerThanLegacyMaxPath_Succeeds()
         {
@@ -285,7 +285,7 @@ public void ExtendedDirectoryLongerThanLegacyMaxPath_Succeeds()
             });
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // long directory path succeeds
         public void DirectoryLongerThanMaxDirectoryAsPath_Succeeds()
         {
@@ -374,7 +374,7 @@ public void TrailingSpace_NotTrimmed(string component)
             Assert.Equal(testDir.FullName, IOServices.RemoveTrailingSlash(result.FullName));
         }
 
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             MemberData(nameof(SimpleWhiteSpace))]
         [PlatformSpecific(TestPlatforms.Windows)]  // extended syntax with whitespace
         public void WindowsExtendedSyntaxWhiteSpace(string path)
@@ -423,7 +423,7 @@ public void PathWithReservedDeviceNameAsPath_ThrowsDirectoryNotFoundException(st
             Assert.Throws<DirectoryNotFoundException>(() => Create(path));
         }
 
-        [ConditionalTheory(nameof(ReservedDeviceNamesAreBlocked), nameof(UsingNewNormalization))] // device name prefixes
+        [ConditionalTheory(nameof(ReservedDeviceNamesAreBlocked))] // device name prefixes
         [MemberData(nameof(ReservedDeviceNames))]
         public void PathWithReservedDeviceNameAsExtendedPath(string path)
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs

@@ -14,10 +14,6 @@ public class Directory_Delete_str : FileSystemTest
 
         static bool IsBindMountSupportedAndPrivilegedProcess => IsBindMountSupported && PlatformDetection.IsPrivilegedProcess;
 
-        static bool IsRemoteExecutorSupportedAndUsingNewNormalization => RemoteExecutor.IsSupported && UsingNewNormalization;
-
-        static bool IsRemoteExecutorSupportedAndLongPathsAreNotBlockedAndUsingNewNormalization => RemoteExecutor.IsSupported && LongPathsAreNotBlocked && UsingNewNormalization;
-
         #region Utilities
 
         protected virtual void Delete(string path)
@@ -126,7 +122,7 @@ public void DeletingSymLinkDoesntDeleteTarget()
             Assert.False(Directory.Exists(linkPath), "linkPath should no longer exist");
         }
 
-        [ConditionalFact(nameof(IsRemoteExecutorSupportedAndUsingNewNormalization))]
+        [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
         public void ExtendedDirectoryWithSubdirectories()
         {
             RemoteExecutor.Invoke(() =>
@@ -139,7 +135,7 @@ public void ExtendedDirectoryWithSubdirectories()
             }).Dispose();
         }
 
-        [ConditionalFact(nameof(IsRemoteExecutorSupportedAndLongPathsAreNotBlockedAndUsingNewNormalization))]
+        [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
         public void LongPathExtendedDirectory()
         {
             RemoteExecutor.Invoke(() =>
@@ -166,7 +162,7 @@ public void WindowsDeleteReadOnlyDirectory()
             testDir.Attributes = FileAttributes.Normal;
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Deleting extended readonly directory throws IOException
         public void WindowsDeleteExtendedReadOnlyDirectory()
         {
@@ -197,7 +193,7 @@ public void WindowsShouldBeAbleToDeleteHiddenDirectory()
             Assert.False(testDir.Exists);
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Deleting extended hidden directory succeeds
         public void WindowsShouldBeAbleToDeleteExtendedHiddenDirectory()
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Exists.cs

@@ -159,7 +159,7 @@ public void SymlinkToNewDirectory()
 
         #region PlatformSpecific
 
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             MemberData(nameof(ValidPathComponentNames))]
         [PlatformSpecific(TestPlatforms.Windows)]  // Extended path exists
         public void ValidExtendedPathExists_ReturnsTrue(string component)
@@ -169,7 +169,7 @@ public void ValidExtendedPathExists_ReturnsTrue(string component)
             Assert.True(Exists(path));
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Extended path already exists as directory
         public void ExtendedPathAlreadyExistsAsDirectory()
         {
@@ -181,7 +181,7 @@ public void ExtendedPathAlreadyExistsAsDirectory()
             Assert.True(Exists(IOServices.RemoveTrailingSlash(IOServices.AddTrailingSlashIfNeeded(path))));
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Long directory path doesn't throw on Exists
         public void DirectoryLongerThanMaxDirectoryAsPath_DoesntThrow()
         {
@@ -219,7 +219,7 @@ public void DoesCaseSensitiveComparisons()
             Assert.False(Exists(testDir.FullName.ToLowerInvariant()));
         }
 
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             MemberData(nameof(SimpleWhiteSpace))]
         [PlatformSpecific(TestPlatforms.Windows)] // In Windows, trailing whitespace in a path is trimmed appropriately
         public void TrailingWhitespaceExistence_SimpleWhiteSpace(string component)
@@ -347,7 +347,7 @@ public void DriveAsPath()
             Assert.Contains(IOServices.GetReadyDrives(), drive => Exists(drive));
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)] // drive labels
         public void ExtendedDriveAsPath()
         {
@@ -380,7 +380,7 @@ public void PathAlreadyExistsAsFile()
             Assert.False(Directory.Exists(IOServices.RemoveTrailingSlash(IOServices.AddTrailingSlashIfNeeded(path))));
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Extended path already exists as file
         public void ExtendedPathAlreadyExistsAsFile()
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/GetFileSystemEntries_str_str.cs

@@ -300,7 +300,7 @@ public void PatternTests_DosDot(string pattern, string[] sourceFiles, string[] e
         }
 
         // Can't do these without extended path support on Windows, UsingNewNormalization filters appropriately
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             // Periods are optional if left of * or ? and end of match
             InlineData(
                 "foo.*",
@@ -357,7 +357,7 @@ public void PatternTests_DosStar(string pattern, string[] sourceFiles, string[]
         }
 
         // Can't do these without extended path support on Windows, UsingNewNormalization filters appropriately
-        [ConditionalTheory(nameof(UsingNewNormalization)),
+        [Theory,
             InlineData(
                 "foo*.",
                 new string[] { @"foo", @"foo.", @"foo.t", @"foo.tx", @"foo.txt", @"bar.txt", @"foo..", @"foo...", @"foo .", @"foo. . .", @"foo. t" },
@@ -580,7 +580,7 @@ public void WindowsSearchPatternLongSegment()
             GetEntries(testDir.FullName, longName);
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         public void SearchPatternLongPath()
         {
             // Create a destination path longer than the traditional Windows limit of 256 characters

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/GetFiles.cs

@@ -41,7 +41,7 @@ public void EnumerateWithSymLinkToFile()
             Assert.Equal(0, GetEntries(containingFolder.FullName).Count());
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         public void EnumerateFilesOverLegacyMaxPath()
         {
             // We want to test that directories under the legacy MAX_PATH (260 characters, including the null) can iterate files
@@ -61,7 +61,7 @@ public void EnumerateFilesOverLegacyMaxPath()
             Assert.Equal(6, files.Length);
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         public void EnumerateFilesDirectoryOverLegacyMaxPath()
         {
             // Check enumerating when the entire path is over MAX_PATH

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Move.cs

@@ -340,7 +340,7 @@ public void MoveDirectory_FailToMoveLowerCaseDirectoryWhenUpperCaseDirectoryExis
             Assert.Throws<IOException>(() => Move($"{TestDirectory}/foo", $"{TestDirectory}/bar/foo"));
         }
 
-        [ConditionalFact(nameof(AreAllLongPathsAvailable))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Long path succeeds
         public void Path_With_Longer_Than_MaxDirectory_Succeeds()
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/DirectoryInfo/CreateSubdirectory.cs

@@ -207,7 +207,7 @@ public void UnixNonSignificantTrailingWhiteSpace(string component)
             Assert.NotEqual(testDir.FullName, IOServices.RemoveTrailingSlash(result.FullName));
         }
 
-        [ConditionalFact(nameof(UsingNewNormalization))]
+        [Fact]
         [PlatformSpecific(TestPlatforms.Windows)]  // Extended windows path
         public void ExtendedPathSubdirectory()
         {

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/DisabledFileLockingTests/System.IO.FileSystem.DisabledFileLocking.Tests.csproj

@@ -23,7 +23,6 @@
     <Compile Include="..\PortedCommon\IOServices.cs" />
     <Compile Include="$(CommonPath)DisableRuntimeMarshalling.cs"
              Link="Common\DisableRuntimeMarshalling.cs" />
-    <Compile Include="$(CommonTestPath)System\IO\PathFeatures.cs" Link="Common\System\IO\PathFeatures.cs" />
     <Compile Include="$(CommonTestPath)Tests\TheoryDataExtensions.cs" Link="Common\Tests\TheoryDataExtensions.cs" />
     <Compile Include="$(CommonTestPath)TestUtilities\System\DisableParallelization.cs" Link="Common\TestUtilities\System\DisableParallelization.cs" />
   </ItemGroup>