Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 15, 2025

#120096 was trying to make build analysis go green if docs-only changes are detected. There is a suspicion it does not work properly.

@ilonatommy ilonatommy self-assigned this Oct 15, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 15, 2025
@ilonatommy ilonatommy added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 15, 2025
@jkotas
Copy link
Member

jkotas commented Oct 21, 2025

@ilonatommy I just run into this with #120938.

@ilonatommy
Copy link
Member Author

Yes, I did not have time to look at it since I noticed suspiciously long run of #120749 (comment) and decided to make this PR to re-test

@ilonatommy
Copy link
Member Author

ilonatommy commented Oct 21, 2025

We most probably have to bind this action with AzDo pipeline pointing to the path with yml and I haven't done it.

Edit:
Requested, waiting.

@ilonatommy ilonatommy closed this Oct 22, 2025
@ilonatommy ilonatommy reopened this Oct 22, 2025
Added note about reopening not triggering Build Analysis.
@ilonatommy
Copy link
Member Author

Still not perfect. Build Analysis seems to ignore the new pipeline.

@ilonatommy
Copy link
Member Author

@haruna99 investigated the issue and explained that in runtime, we have Build Analysis filters that are not present in aspnetcore repo. We have to update config file acoording to the instruction. Working on it.

ilonatommy added a commit that referenced this pull request Oct 31, 2025
This PR adds a pipeline to config file that defines which pipelines are
taken into consideration during Build Analysis.

Contributes to #120752.
@ilonatommy
Copy link
Member Author

Working. Closing

image

@ilonatommy ilonatommy closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants