Skip to content

Update XmlSchemaSet.cs #120661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update XmlSchemaSet.cs #120661

wants to merge 1 commit into from

Conversation

@wstaelens
Copy link

@wstaelens wstaelens commented Oct 13, 2025 •
edited
Loading

performance: removes arraylists

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 13, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

There is no boxing because XmlSchema is a reference type. The performance difference is negligible.

There are a lot of opportunities for code modernization in System.Xml codebase. Please do not open PR for a single case.

@huoyaoyuan huoyaoyuan mentioned this pull request Oct 13, 2025
Open
@wstaelens
Copy link
Author

There is no boxing because XmlSchema is a reference type. The performance difference is negligible.

There are a lot of opportunities for code modernization in System.Xml codebase. Please do not open PR for a single case.

feel free to further improve yourself, or accept this approvement.
regarding (un)boxing: true.

anyway: any gain is a gain.

@huoyaoyuan
Copy link
Member

feel free to further improve yourself, or accept this approvement. regarding (un)boxing: true.

anyway: any gain is a gain.

There are 5 usages of ArrayList in the file XmlSchemaSet.cs, and hundreds more in entire `System.Private.Xml. Can you address more of them?

Without a performance measurement number, it's a code quality improvement.

@SadPencil SadPencil mentioned this pull request Oct 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area-System.Xml community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wstaelens @huoyaoyuan