Skip to content

[RuntimeAsync] Removing Experimental attribute from async helpers. #120585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

[RuntimeAsync] Removing Experimental attribute from async helpers. #120585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
namespace System.Runtime.CompilerServices
{
[System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
[System.Diagnostics.CodeAnalysis.ExperimentalAttribute("SYSLIB5007", UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
public static partial class AsyncHelpers
{
#if CORECLR
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Runtime/ref/System.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14138,7 +14138,6 @@ public static void RunModuleConstructor(System.ModuleHandle module) { }
public delegate void TryCode(object? userData);
}
[System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
[System.Diagnostics.CodeAnalysis.ExperimentalAttribute("SYSLIB5007", UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
public static partial class AsyncHelpers
{
[System.Runtime.Versioning.RequiresPreviewFeaturesAttribute]
Expand Down
2 changes: 0 additions & 2 deletions ...ests/async/fibonacci-without-yields-config-await/fibonacci-without-yields-config-await.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
using System.Runtime.CompilerServices;
using Xunit;

#pragma warning disable SYSLIB5007 // 'System.Runtime.CompilerServices.AsyncHelpers' is for evaluation purposes only

public class Async2FibonacciWithYields
{
const int iterations = 3;
Expand Down
4 changes: 0 additions & 4 deletions src/tests/async/reflection/reflection-simple.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public static void MethodInfo_Invoke_TaskReturning()
Assert.Equal(100, (int)(r.Result + d.Bar().Result));
}

#pragma warning disable SYSLIB5007 // 'System.Runtime.CompilerServices.AsyncHelpers' is for evaluation purposes only
[Fact]
public static void MethodInfo_Invoke_AsyncHelper()
{
Expand All @@ -37,7 +36,6 @@ public static void MethodInfo_Invoke_AsyncHelper()
// dynamic d = FooTask();
// System.Runtime.CompilerServices.AsyncHelpers.Await(d);
}
#pragma warning restore SYSLIB5007

private static async Task<int> Foo()
{
Expand Down Expand Up @@ -164,9 +162,7 @@ public static void TypeBuilder_DefineMethod()
// }
ILGenerator ilGenerator = methodBuilder.GetILGenerator();
ilGenerator.Emit(OpCodes.Ldarg_0);
#pragma warning disable SYSLIB5007 // 'System.Runtime.CompilerServices.AsyncHelpers' is for evaluation purposes only
var mi = typeof(System.Runtime.CompilerServices.AsyncHelpers).GetMethod("Await", BindingFlags.Static | BindingFlags.Public, new Type[] { typeof(Task) })!;
#pragma warning restore SYSLIB5007
ilGenerator.EmitCall(OpCodes.Call, mi, new Type[] { typeof(Task) });
ilGenerator.Emit(OpCodes.Ret);

Expand Down
Loading