Use switch statement to map socket errors #120364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
jkotas
added
area-System.Net
and removed
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the socket error mapping implementation by replacing dictionary-based lookups with switch expressions for better performance and readability.
Key changes:
- Replaces dictionary-based error mapping with switch expressions
- Removes debug assertions and associated constants for dictionary count validation
- Consolidates mapping logic into shared helper methods
src/libraries/Common/src/System/Net/Sockets/SocketErrorPal.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Net/Sockets/SocketErrorPal.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Net/Sockets/SocketErrorPal.Unix.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/ncl |
jkotas
changed the title
…x.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…x.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stephentoub
reviewed
Oct 3, 2025
src/libraries/Common/src/System/Net/Sockets/SocketErrorPal.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 3, 2025
…x.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
bartonjs
approved these changes
Oct 3, 2025
This was referenced Oct 3, 2025
12 tasks
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18288262494 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #120352 (comment)