Skip to content

Add missing TlsAlertMessage members #120260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Add missing TlsAlertMessage members #120260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe0184
Add missing TlsAllertMessages
rzikm Sep 30, 2025
cc65ce4
Fix tests build
rzikm Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/libraries/Common/src/System/Net/Security/TlsAlertMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ internal enum TlsAlertMessage
RecordOverflow = 22, // error
DecompressionFail = 30, // error
HandshakeFailure = 40, // error
NoCertificate = 41, // reserved - Used in SSLv3 but not in TLS
BadCertificate = 42, // warning or error
UnsupportedCert = 43, // warning or error
CertificateRevoked = 44, // warning or error
Expand All @@ -22,12 +23,24 @@ internal enum TlsAlertMessage
AccessDenied = 49, // error
DecodeError = 50, // error
DecryptError = 51, // error
TooManyCidsRequested = 52, // error
ExportRestriction = 60, // reserved
ProtocolVersion = 70, // error
InsuffientSecurity = 71, // error
InsufficientSecurity = 71, // error
InternalError = 80, // error
InappropriateFallback = 86, // error
UserCanceled = 90, // warning or error
NoRenegotiation = 100, // warning
UnsupportedExt = 110, // error
MissingExtension = 109, // error
UnsupportedExtension = 110, // error
CertificateUnobtainable = 111, // reserved - Used in TLS versions prior to 1.3
UnrecognizedName = 112, // error
BadCertificateStatusResponse = 113, // error
BadCertificateHashValue = 114, // reserved - Used in TLS versions prior to 1.3
UnknownPskIdentity = 115, // error
CertificateRequired = 116, // error
GeneralError = 117, // error
NoApplicationProtocol = 120, // error
EchRequired = 121, // error
}
}
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Security/tests/UnitTests/TlsAlertsMatchWindowsInterop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ public void TlsAlertEnums_MatchWindowsInterop_Ok()
Assert.Equal((int)TlsAlertMessage.DecryptError, Interop.SChannel.TLS1_ALERT_DECRYPT_ERROR);
Assert.Equal((int)TlsAlertMessage.ExportRestriction, Interop.SChannel.TLS1_ALERT_EXPORT_RESTRICTION);
Assert.Equal((int)TlsAlertMessage.ProtocolVersion, Interop.SChannel.TLS1_ALERT_PROTOCOL_VERSION);
Assert.Equal((int)TlsAlertMessage.InsuffientSecurity, Interop.SChannel.TLS1_ALERT_INSUFFIENT_SECURITY);
Assert.Equal((int)TlsAlertMessage.InsufficientSecurity, Interop.SChannel.TLS1_ALERT_INSUFFIENT_SECURITY);
Assert.Equal((int)TlsAlertMessage.InternalError, Interop.SChannel.TLS1_ALERT_INTERNAL_ERROR);
Assert.Equal((int)TlsAlertMessage.UserCanceled, Interop.SChannel.TLS1_ALERT_USER_CANCELED);
Assert.Equal((int)TlsAlertMessage.NoRenegotiation, Interop.SChannel.TLS1_ALERT_NO_RENEGOTIATION);
Assert.Equal((int)TlsAlertMessage.UnsupportedExt, Interop.SChannel.TLS1_ALERT_UNSUPPORTED_EXT);
Assert.Equal((int)TlsAlertMessage.UnsupportedExtension, Interop.SChannel.TLS1_ALERT_UNSUPPORTED_EXT);
}
}
}
Loading