Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Sep 22, 2025

@xtqqczze xtqqczze marked this pull request as draft September 22, 2025 14:27
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 22, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 22, 2025
@MihaZupan
Copy link
Member

MihaZupan commented Sep 22, 2025

#119673 is also adding framework polyfills for new APIs.

My preference would be to get that reviewed first, so that we can use a common switch of including such helper files in projects.

I also had changes for Encoding and Span.Contains APIs sitting in a branch since they depend on the PR mentioned above being merged first:

@MihaZupan
Copy link
Member

@xtqqczze Do you think it's worth moving forward here given that MihaZupan@e819ccb already has a superset of these changes?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Sep 22, 2025

@xtqqczze Do you think it's worth moving forward here given that MihaZupan@e819ccb already has a superset of these changes?

I don't see string.Contains methods in those changes, only ReadOnlySpan<T>.Contains. Looks like it touches many of the same files though.

* Use C# 14 extension members to polyfill the required APIs
* Remove suppression of CA2249: Consider using 'string.Contains' instead of 'string.IndexOf'
@dotnet-policy-service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants