Disable test which requires AssemblyDependencyResolver on mobile #119801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile runtimes AssemblyDependencyResolver is not implement and throws. Tests which rely on it will fail. Disabling two new tests which are hitting this condition.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables tests that rely on AssemblyDependencyResolver on mobile platforms where this functionality is not implemented. The change updates platform-specific test conditions to use the broader "mobile" category instead of just "browser" platforms.
- Updates platform detection conditions from browser-specific to mobile-specific
- Disables two TypeDescriptor tests that require AssemblyDependencyResolver on mobile platforms
- Ensures consistent platform handling across test conditions and actual test logic
github-actions
bot
added
the
needs-area-label
vitek-karas
added
os-android
area-AssemblyLoader-mono
os-ios
Contributor
|
Tagging subscribers to this area: |
akoeplinger
reviewed
Sep 17, 2025
src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Sep 18, 2025
xtqqczze
pushed a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Sep 20, 2025
…net#119801) On mobile runtimes AssemblyDependencyResolver is not implement and throws. Tests which rely on it will fail. Disabling two new tests which are hitting this condition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile runtimes AssemblyDependencyResolver is not implement and throws. Tests which rely on it will fail. Disabling two new tests which are hitting this condition.