Remove SR.Argument_NeedStructWithNoRefs
#119493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the `SR.Argument_NeedStructWithNoRefs` resource string and updates the corresponding `ArgumentException` message to be more descriptive.
The old message was:
```
The specified Type must be a struct containing no references.
```
This has been replaced with:
```
Cannot use type '{0}'. Only value types without pointers or references are supported.
```
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
The exception message could even be simplified to: |
Member
Yes, the existing message is misleading. Value types with (unmanaged) pointers are supported by these APIs. Also, the ThrowHelper name should be updated to match. Could you please make these fixes? |
jkotas
reviewed
Sep 9, 2025
This was referenced Sep 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
SR.Argument_NeedStructWithNoRefsresource string and updates the correspondingArgumentExceptionmessage to be more descriptive.The old message was:
This has been replaced with: