Use unpredicated movprfx with SVE2 fminnmp and fmaxnmp #119390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codegen is currently emitting a predicated `movprfx` with these instructions in combination with `ConditionalSelect`, which results in unpredictable behaviour. Use unpredicated `movprfx` instead and apply the mask to the result of the instruction.
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
a74nh
requested review from
a74nh and
tannergooding
and removed request for
a74nh
a74nh
added
Priority:0
Member
|
@tannergooding and @EgorBo, please review this PR. The two commands (fminmp and fmaxmp) generate wrong values sometimes without this fix. We want to put this into .NET 10. |
…o movprfx optimization
tannergooding
approved these changes
Sep 15, 2025
Member
|
@EgorBo, please backport to .NET 10. |
EgorBo
approved these changes
Sep 17, 2025
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17796691039 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen is currently emitting a predicated
movprfxwith these instructions in combination withConditionalSelect, which results in unpredictable behaviour. Use unpredicatedmovprfxinstead and apply the mask to the result of the instruction.