JIT: Handle more unsupported argument conversion cases #119328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit platforms we can end up with long operands to a function taking a parameter in a double. We would try to create bitcasts for this cast. Generalize a condition to properly detect this unsupported case.
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a JIT compilation issue on 32-bit platforms where long operands passed to functions expecting parameters in double registers would incorrectly attempt unsupported bitcast operations. The fix generalizes the detection of unsupported argument conversion cases.
Key changes:
- Removes an incorrect assertion about register/stack slot counts for long arguments
- Generalizes the condition for detecting unsupported int-to-float register conversions beyond just SIMD types
jakobbotsch
commented
Sep 4, 2025
AndyAyersMS
approved these changes
Sep 4, 2025
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17491769642 |
Contributor
|
@jakobbotsch backporting to "release/10.0" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: JIT: Handle more unsupported argument conversion cases
Using index info to reconstruct a base tree...
M src/coreclr/jit/lower.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/jit/lower.cpp
CONFLICT (content): Merge conflict in src/coreclr/jit/lower.cpp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 JIT: Handle more unsupported argument conversion cases
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit platforms we can end up with long operands to a function taking a parameter in a double register. We would try to create bitcasts for this case, which is not supported for 32 bit.
Generalize a condition to properly detect this unsupported case.
Fix #119062