[DAC] GetSyncBlockData properly count waiting threads #119319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while implementing
ISOSDacInterface::GetSyncBlockDatain the cDAC. #119320The DAC version of this API is intended to iterate the
SListof waiting threads with a maximum cap of 1000.However, the
pLinkpointer is never actually modified in the loop so if there are any waiting threads, the API will always return the maximum cap.