JIT: Always remove commas while splitting #119275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to keep the commas around, and for some struct IR it results in illegal IR (e.g. when splitting COMMA(op1, FIELD_LIST(...))).
github-actions
bot
added
the
area-CodeGen-coreclr
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a JIT issue where comma operators were sometimes incorrectly preserved during tree splitting, leading to illegal IR in certain cases. The fix ensures that comma operators are always properly removed during the splitting process.
Key changes:
- Added logic to automatically remove comma operators during tree splitting
- Prevents generation of illegal IR when splitting structures like
COMMA(op1, FIELD_LIST(...))
Comments suppressed due to low confidence (1)
src/coreclr/jit/gentree.cpp:1
- The code modifies
*useat line 17171 but then uses the originaluseInfparameter at line 17172, which still references the old comma node. After line 17171,useInfshould be updated to reflect the new use location, or a new UseInfo should be created for the second operand.
// Licensed to the .NET Foundation under one or more agreements.
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS Some improvements, but most of all ensures we can split the IR shape mentioned above. |
AndyAyersMS
approved these changes
Sep 2, 2025
filipnavara
pushed a commit
to filipnavara/runtime
that referenced
this pull request
Sep 5, 2025
There is no reason to keep the commas around, and for some struct IR it results in illegal IR (e.g. when splitting COMMA(op1, FIELD_LIST(...))).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to keep the commas around, and for some struct IR it results in illegal IR (e.g. when splitting COMMA(op1, FIELD_LIST(...))).
Fixes an issue I hit over in #118778