[release/10.0] JIT: handle commas during inline return value substitution#119271
Merged
jeffschwMSFT merged 4 commits intorelease/10.0from Sep 5, 2025
Merged
[release/10.0] JIT: handle commas during inline return value substitution#119271jeffschwMSFT merged 4 commits intorelease/10.0from
jeffschwMSFT merged 4 commits intorelease/10.0from
Conversation
Member
|
@dotnet/jit-contrib PTAL |
jeffschwMSFT
approved these changes
Sep 2, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
Member
|
@EgorBo PTAL |
EgorBo
approved these changes
Sep 3, 2025
Member
|
Build error is similar to #119249 |
Member
|
/ba-g known error #119249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119160 to release/10.0
/cc @AndyAyersMS
Customer Impact
Found via Fuzzlyn.
When we inline certain kinds of return values into a predicate context, we may fail to form proper JIT IR. Existing test does not fail in release, but the malformed IR may in other similar examples cause the JIT to crash or produce incorrect code.
Regression
Fails the same way with .NET 9; not sure about earlier.
Testing
Added the repro case as a test; no diffs elsewhere.
Risk
Low. Seems to be an uncommon pattern.