[release/10.0] limit regions_range to 2x physical_mem for WKS #119192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
approved these changes
Aug 29, 2025
jeffschwMSFT
approved these changes
Aug 29, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please fill in the template. when ready we can merge
jeffschwMSFT
added
Servicing-approved
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
Maoni0
approved these changes
Aug 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118516 to release/10.0
/cc @mangod9
Customer Impact
This change updates the Regions Memory Reservation size for WKS where only 2x physical memory is reserved instead of the max of (256gb, 2 x physical). This would mean WKS workloads requiring 256gb + will have to manually configure RegionsRange.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Fix has been verified by running GCPerfSim scenarios to ensure there are no regressions in perf or memory utilization.
Risk
Medium. This does change the behavior of how much memory is reserved, so if there are scenarios where there are multiple processes consuming large enough memory there could be some tradeoffs, but we feel such scenarios running with WKS is rate.