-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix elfreader for android #119190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix elfreader for android #119190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with the ELF reader on Android by extending a conditional compilation block to include Android platforms. The change addresses how dynamic entries are handled on Android, treating them as relative virtual addresses (RVAs) rather than absolute addresses.
Key Changes
- Extended preprocessor condition to include Android (
HOST_ANDROID) alongside existing musl and RISC-V64 platforms
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307193266 |
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307334479 |
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17307346724 |
|
Thanks @jkotas, I tested locally and the TARGET_ANDROID worked fine too. |
This PR fixes an issue with the ELF reader on Android by extending a conditional compilation block to include Android platforms. The change addresses how dynamic entries are handled on Android, treating them as relative virtual addresses (RVAs) rather than absolute addresses.