Skip to content

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 26, 2025

To 4.14.0.

Silence the warnings for now to avoid introducing a bunch of code changes that are unnecessary for .NET 10.

@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 21:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Microsoft.CodeAnalysis version from 4.8.0 to 4.14.0 and silences new warnings to maintain compatibility without requiring extensive code changes for .NET 10.

  • Updates MicrosoftCodeAnalysisVersion_LatestVS from 4.8.0 to 4.14.0
  • Removes conditional restriction on CS0436 warning suppression in ILLink.RoslynAnalyzer
  • Adds global suppression for IDE0100 (redundant equality) and IDE0060 (unused parameters) warnings

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Updates Microsoft.CodeAnalysis version from 4.8.0 to 4.14.0
src/tools/illink/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj Removes condition from CS0436 warning suppression to apply globally
Directory.Build.props Adds global suppression for IDE0100 and IDE0060 warnings

@github-actions github-actions bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Aug 26, 2025
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Aug 26, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@sbomer
Copy link
Member Author

sbomer commented Aug 28, 2025

Merged this into #119017

@sbomer sbomer closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant