[release/10.0] Fixes trying to create a module using a trash as the address of the module#119063
Merged
jeffschwMSFT merged 1 commit intorelease/10.0from Sep 2, 2025
Merged
Conversation
jeffschwMSFT
approved these changes
Aug 26, 2025
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please fill in the template and get a code review. we can merge when ready
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
steveisok
approved these changes
Aug 29, 2025
Member
Done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119031 to release/10.0
/cc @thaystg
Customer Impact
While implementing the Android CoreCLR debugger, we found an issue where we would create a module using garbage as the address of the module. This happened likely because of the change we made in #118414 where the following code can contain a trash value:
pModule = m_modules.GetBase(VmPtrToCookie(vmModule));Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually tested when debugging on android.
Risk
Low, only initializing an empty field.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.