-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957
Conversation
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failures in CI to look at: console log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM to me now. Thanks.
If possible it would be good to get this into .NET10 as it will then finish the FP group. |
cc @dotnet/jit-contrib for code review. |
@a74nh we will try. Even though it's a small change, it would need approval for adding new APIs into .NET 10 RC2 so we need to be extra thorough. We have low availability the next couple of weeks to achieve that. But if we do get it merged in next week, we can seek approval to backport it into .NET 10. /cc @artl93 for heads-up this might be a candidate for RC2 backport next week as it would finish the Floating Point category of Arm intrinsics, and it's all within an |
Ok thanks, understood. #119201 is also waiting, but that one is a new group (scatters), and there will be a follow on to PR to finish the group. So if we can't get both the scatters into .NET 10, then it'll be better to leave those two until 11. |
@SwapnilGaikwad Can you resolve the merge conflicts that have arisen please? |
Done. |
Contributes to #94018
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Co-authored-by: @jacob-crawley