Skip to content

Conversation

SwapnilGaikwad
Copy link
Contributor

Contributes to #94018

@dotnet/arm64-contrib @amanasifkhalid @a74nh

Co-authored-by: @jacob-crawley

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 21, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failures in CI to look at: console log.

Copy link
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM to me now. Thanks.

@a74nh
Copy link
Contributor

a74nh commented Sep 3, 2025

@jeffhandley jeffhandley added this to the 11.0.0 milestone yesterday

If possible it would be good to get this into .NET10 as it will then finish the FP group.

@JulieLeeMSFT
Copy link
Member

cc @dotnet/jit-contrib for code review.

@jeffhandley
Copy link
Member

@a74nh we will try. Even though it's a small change, it would need approval for adding new APIs into .NET 10 RC2 so we need to be extra thorough. We have low availability the next couple of weeks to achieve that. But if we do get it merged in next week, we can seek approval to backport it into .NET 10.

/cc @artl93 for heads-up this might be a candidate for RC2 backport next week as it would finish the Floating Point category of Arm intrinsics, and it's all within an [Experimental] class of APIs.

@a74nh
Copy link
Contributor

a74nh commented Sep 4, 2025

@a74nh we will try. Even though it's a small change, it would need approval for adding new APIs into .NET 10 RC2 so we need to be extra thorough. We have low availability the next couple of weeks to achieve that. But if we do get it merged in next week, we can seek approval to backport it into .NET 10.

Ok thanks, understood.

#119201 is also waiting, but that one is a new group (scatters), and there will be a follow on to PR to finish the group. So if we can't get both the scatters into .NET 10, then it'll be better to leave those two until 11.

@jeffhandley jeffhandley requested a review from a team September 4, 2025 23:07
@jeffhandley
Copy link
Member

@SwapnilGaikwad Can you resolve the merge conflicts that have arisen please?

@SwapnilGaikwad
Copy link
Contributor Author

@SwapnilGaikwad Can you resolve the merge conflicts that have arisen please?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants