Add trim analysis for implicit constructors #118755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds trim analysis for implicit constructors to address issue #106796. The change ensures that when a class inherits from another class with RequiresUnreferencedCode annotations, the analyzer properly detects and warns about the implicit constructor call to the base class constructor.
Key changes:
- Enhanced the RequiresUnreferencedCodeAnalyzer to analyze implicit base constructor calls
- Added test case updates to verify the new analysis behavior with expected warnings
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RequiresUnreferencedCodeAnalyzer.cs | Added analysis logic for implicit base constructor calls in derived classes |
| RequiresOnClass.cs | Added expected warnings and instantiation calls for test consistency between analyzer and trimmer |
| RequiresExcludeStatics.cs | Added expected warning for implicit base constructor call |
src/tools/illink/src/ILLink.RoslynAnalyzer/RequiresUnreferencedCodeAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/src/ILLink.RoslynAnalyzer/RequiresUnreferencedCodeAnalyzer.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @dotnet/illink |
This was warning on the implicit ctor.
jtschuster
approved these changes
Aug 15, 2025
Member
|
/ba-g failures are unrelated |
Member
|
@sbomer I assume you were hoping to get this into 10? |
Member
Author
|
/backport to release/10.0-rc1 |
Contributor
|
Started backporting to release/10.0-rc1: https://github.com/dotnet/runtime/actions/runs/17047926123 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106796