Allow unsafe blocks because of ApkBuilder #118721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnguyen-tech
merged commit 0e141db
into
dotnet:copilot/fix-118162
0 of 2 checks passed
davidnguyen-tech
added a commit
that referenced
this pull request
Aug 14, 2025
…okup in ApkBuilder (#118674) * Initial plan * Fix AndroidAppBuilder to use assembly name for runtimeconfig.json lookup Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com> * Update AndroidAppBuilder to use runtimeconfig.bin instead of assembly-specific runtimeconfig.json Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com> * Add documentation comment explaining binary format source in ParseRuntimeConfigProperties Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com> * Replace custom Read methods with existing BlobReader from System.Reflection.Metadata Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com> * Simplify runtime config parsing by removing manual file existence check Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com> * Allow unsafe blocks because of ApkBuilder (#118721) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: davidnguyen-tech <87228593+davidnguyen-tech@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.