Simplify/fix loop descriptions in regex source generator #118341
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There's no need to say "greedily and atomically"... "atomically" covers it. - "lazily and atomically" doesn't make sense... "lazily" covers it.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies loop descriptions in the regex source generator by removing redundant qualifiers and fixing logical inconsistencies in the description strings.
- Removes redundant "greedily and atomically" description, keeping just "atomically" since atomic matching inherently covers greedy behavior
- Fixes illogical "lazily and atomically" description, keeping just "lazily" since lazy matching is incompatible with atomic matching
- Consolidates the default case to simply return "lazily" with a clarifying comment
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions |
MihaZupan
approved these changes
Aug 4, 2025
|
/ba-g The error is #105177, the PR that closed it was merged after the build on this PR started |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects emitted comments.