Skip to content

[QUIC] Do async validation only from > 2.4, i.e. 2.4.1+ #118339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Aug 4, 2025

The OSX QUIC timeouts are likely an instance of microsoft/msquic#4132.

On OSX, We're using MsQuic at this commit: microsoft/msquic@e0385b0 build from main (therefore having version of the next release - 2.4).
Historically, the above mentioned issue had a fix by that time: microsoft/msquic#4145
Unfortunately, the were at least 2 follow ups it seems:

Which are not part of the binaries with which we're testing.

TL;DR This should get fixed by new MsQuic, i.e. with #114912

This is an alternative which changes the async cert validation condition to > in here:

internal static bool SupportsAsyncCertValidation => Version >= new Version(2, 4);

Note that both Windows and latest Linux MsQuic binaries are 2.4.8 so this shouldn't have any effect on customers.

Fixes #107761
Fixes #105177
Fixes #103482
Fixes #104426

@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 14:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses QUIC test timeouts on macOS by adjusting the version check for async certificate validation support. The change is a workaround for a known MsQuic issue that affects version 2.4 but is resolved in later versions.

Key changes:

  • Modified the version comparison for async certificate validation from >= to > for MsQuic version 2.4
  • Updated the comment formatting for consistency

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ManickaP ManickaP merged commit e205dae into dotnet:main Aug 4, 2025
89 checks passed
@ManickaP ManickaP deleted the quic-osx branch August 4, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants