Start using parameter defined for ToString #118306
Open
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in existing behavior.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where a ToString(IFormatProvider) method in the DateTimeOffsetAdapter struct was accepting but ignoring its format provider parameter, causing compiler warnings. The fix implements proper usage of the format provider parameter while maintaining existing behavior by passing null at the call site.
Key Changes
- Updates the
ToString(IFormatProvider?)method to actually use the format provider when formatting theUtcDateTime - Changes the call site to pass
nullinstead ofCultureInfo.InvariantCultureto preserve existing behavior - Removes compiler warning suppressions that are no longer needed
....Private.DataContractSerialization/src/System/Runtime/Serialization/DateTimeOffsetAdapter.cs
Outdated
Show resolved
Hide resolved
....Private.DataContractSerialization/src/System/Runtime/Serialization/DateTimeOffsetAdapter.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2025
....Private.DataContractSerialization/src/System/Runtime/Serialization/DateTimeOffsetAdapter.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 4, 2025
....Private.DataContractSerialization/src/System/Runtime/Serialization/DateTimeOffsetAdapter.cs
Outdated
Show resolved
Hide resolved
…tem/Runtime/Serialization/DateTimeOffsetAdapter.cs
jkotas
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, this adapter struct took an
IFormatProvideragrument for it'sToString()method... and never used it. This makes the compiler unhappy now. So to keep the API (partly for binary compat, and partly to not bump heads with Object.ToString()), lets start using the format provider as one might expect. And then pass a null value in the one place that we call this ToString overload so the existing behavior is maintained.Fixes #76012