[release/10.0-preview7] Revert "Show specific error message for dotnet <app_path> where app_path is a non-dll/exe file that exists"
#118065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_path is…" This reverts commit 9d6caae.
jjonescz
approved these changes
Jul 25, 2025
MiYanni
approved these changes
Jul 25, 2025
Member
|
@agocke Howdy, I don't know who does PR failure investigations in the runtime repo. But this PR needs to get into P7 to fix a build failure for the VMR P7 branch. (I don't know the runtime repo/build) |
agocke
approved these changes
Jul 25, 2025
Member
|
@MiYanni Does this need tactics approval? If not I think we can just merge it as soon as tests succeed. |
Member
|
@agocke I'm not sure. The chat I'm in said to just monitor that this gets in. I'll add you to the chat. |
jeffschwMSFT
added
Servicing-approved
This was referenced Jul 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #117937 to release/10.0-preview7
/cc @jjonescz @elinor-fung
Customer Impact
We intended to produce a helpful error message when the user passes a DLL that isn't valid to
dotnet.exe. It turns out that the SDK relies on seeing these arguments as part of thedotnet file.csfeature. Thus, the change broke the feature. This is an automatic revert of the change.Regression
If the revert does not go in, this would regress from P6, where the feature works.
Testing
Existing unit tests in the SDK.
Risk
Low -- automated revert.