Enable Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations
#117985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables a previously disabled WebAssembly template test by removing the [ActiveIssue] attribute and fixing the underlying issue with project path resolution when running tests outside the project directory.
Key Changes
- Removes the
[ActiveIssue]attribute that was disabling theRunWithDifferentAppBundleLocationstest - Fixes project path resolution logic to handle cases where tests run outside the project directory
- Updates the dotnet run commands to use the corrected project file path
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Jul 23, 2025
Open
Member
Author
|
Merging of this should wait for #117772 to be fixed. |
pavelsavara
approved these changes
Jul 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active issue was #108107. Let's see if CI catches more errors. Running locally on repeat did not reveal any problems. The layout of project changed, so we had to update the project path to fix it.