Remove warning for base type with RequiresUnreferencedCode #117944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes IL2109 warnings that occurred when a type without RequiresUnreferencedCode (RUC) derived from a type with RUC. The change makes the behavior consistent between RequiresUnreferencedCode and RequiresDynamicCode, where the latter did not have this warning. The warning is considered unnecessary because constructor calls to the base type will still generate appropriate warnings.
- Removes IL2109 diagnostic code generation from multiple components (ILLink, Roslyn analyzer, and NativeAOT compiler)
- Updates test cases to remove expected IL2109 warnings and related suppressions
- Adds a new test file to verify the behavior with base classes having RUC/RDC attributes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
DiagnosticId.cs |
Marks IL2109 diagnostic ID as unused |
MarkStep.cs |
Removes logic that generates IL2109 warnings for base type inheritance |
RequiresUnreferencedCodeAnalyzer.cs |
Removes Roslyn analyzer logic for IL2109 warnings |
DataflowAnalyzedTypeDefinitionNode.cs |
Removes NativeAOT compiler logic for IL2109 warnings |
RequiresOnClass.cs |
Removes expected IL2109 warnings from test cases and updates class names |
RequiresOnBaseClass.cs |
New test file demonstrating expected behavior with RUC/RDC base classes |
GenericParameterDataFlow.cs |
Removes expected IL2109 warning from generic type test |
RequiresCapabilityTests.cs |
Adds test method for new RequiresOnBaseClass test case |
SuppressWarningsViaXml.xml |
Removes IL2109 suppression attribute from XML configuration |
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
This was referenced Jul 24, 2025
jtschuster
approved these changes
Jul 28, 2025
|
/ba-g "timeouts" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the IL2109 warning about a type without RUC derived from a type with RUC. This existed for RequiresUnreferencedCode but not RequiresDynamicCode.
The warning on the class should not be necessary because there will be a warning for the base ctor call.
Fixes #107660.