Skip to content

[PERF] Removed building of musl artifacts from performance related pipelines #117628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

LoopedBard3
Copy link
Member

Removed building of musl artifacts from performance related pipelines as we no longer have alpine machines to run them for.

To be merged with: dotnet/performance#4886

… as we no longer have alpine machines to run them for.
@LoopedBard3 LoopedBard3 self-assigned this Jul 14, 2025
@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 22:00
@LoopedBard3 LoopedBard3 added the perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines label Jul 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the build of musl (Alpine) artifacts from the performance pipelines since Alpine machines are no longer available.

  • Drop the linux_musl_x64 parameter and related conditionals in CoreCLR build jobs
  • Remove linux_musl_x64 from the performance build-jobs template
  • Eliminate the coreclr_muslx64_linux parameter and its references in perf-build.yml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/pipelines/performance/templates/perf-coreclr-build-jobs.yml Removed musl parameter and its conditional job entries
eng/pipelines/performance/templates/perf-build-jobs.yml Dropped linux_musl_x64 default argument
eng/pipelines/performance/perf-build.yml Deleted coreclr_muslx64_linux parameter and its uses

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 14, 2025
Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit b4fb38c into dotnet:main Jul 15, 2025
28 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfRemoveMuslBuilds branch July 15, 2025 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants