-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono][browser] Enable failing tests in smoke tests #117585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lewing
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
lewing:aot-madness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a15146c
Enable failing tests in smoke tests
lewing dee56cd
fix formatting
lewing 5872214
Add more failing tests
lewing 67415fe
Merge branch 'main' into aot-madness
lewing 4163f04
Merge branch 'main' into aot-madness
lewing 68299e6
Merge branch 'main' into aot-madness
lewing 26167cd
Merge branch 'main' into aot-madness
lewing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -539,6 +539,10 @@ | |||||
| <!-- browser smoke tests --> | ||||||
| <ItemGroup Condition="'$(TargetOS)' == 'browser'"> | ||||||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime.Intrinsics\tests\System.Runtime.Intrinsics.Tests.csproj" /> | ||||||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Memory\tests\System.Memory.Tests.csproj" /> | ||||||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" /> | ||||||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.IO.UnmanagedMemoryStream.Tests/System.IO.UnmanagedMemoryStream.Tests.csproj" /> | ||||||
| <SmokeTestProject Include="$(MSBuildThisFileDirectory)System.Diagnostics.StackTrace/tests/System.Diagnostics.StackTrace.Tests.csproj" /> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] This path uses forward slashes inconsistently compared to other entries. Consider using backslashes like the other entries for consistency:
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| </ItemGroup> | ||||||
|
|
||||||
| <!-- wasi/interp smoke tests --> | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This path uses forward slashes inconsistently compared to other entries. Consider using backslashes like the other entries for consistency:
System.Runtime\tests\System.IO.UnmanagedMemoryStream.Tests\System.IO.UnmanagedMemoryStream.Tests.csprojCopilot uses AI. Check for mistakes.