-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Run host tests on osx_arm64 #117434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run host tests on osx_arm64 #117434
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
6427262
to
660ccc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for running host tests on macOS ARM64 by replacing the old AllSubsets_CoreCLR
job with a new CoreCLR_Libraries
build, updating the pipeline matrix, and fixes a test-only behavior ordering issue in one of the host activation tests.
- Replace
AllSubsets_CoreCLR
withCoreCLR_Libraries
job to buildclr+libs
for host tests. - Add
osx_arm64
to the host test run matrix. - Ensure test-only behavior is enabled before loading the binary in the framework resolution test.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/installer/tests/HostActivation.Tests/FrameworkResolution/FrameworkResolution.cs | Enable test-only behavior before the hostfxr binary is loaded to avoid macOS SIP reload crashes. |
eng/pipelines/runtime.yml | Remove old CoreCLR subset job, insert new CoreCLR_Libraries build for osx_arm64 , and add osx_arm64 to the host test job. |
Comments suppressed due to low confidence (2)
eng/pipelines/runtime.yml:208
- The
CoreCLR_Libraries
job only buildsclr+libs
but the host tests require the host binaries and packs. Change this to-s clr+libs+host+packs
(or whatever subset names include the host) to ensure the host executables are available for test runs.
buildArgs: -s clr+libs -c $(_BuildConfig)
eng/pipelines/runtime.yml:1279
- The indentation of this
- osx_arm64
entry differs from the- windows_x86
line above, which may lead to YAML parsing errors or omit macOS ARM64 from the matrix. Align it to match the existing list indentation.
- osx_arm64
osx-arm64 job from this PR
Contributes to #77800
cc @dotnet/appmodel