Skip to content

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jul 8, 2025

  • Replace AllSubsets_CoreCLR job for osx-arm64 with a CoreCLR_Libraries job that builds release clr+libs for running host tests
  • Add osx-arm64 platform for host test runs (depends on CoreCLR_Libraries job).
  • Fix issue in test around enabling test-only behaviour after the binary was already loaded

osx-arm64 job from this PR

Contributes to #77800

cc @dotnet/appmodel

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 8, 2025
@elinor-fung elinor-fung added area-Host and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 8, 2025
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for running host tests on macOS ARM64 by replacing the old AllSubsets_CoreCLR job with a new CoreCLR_Libraries build, updating the pipeline matrix, and fixes a test-only behavior ordering issue in one of the host activation tests.

  • Replace AllSubsets_CoreCLR with CoreCLR_Libraries job to build clr+libs for host tests.
  • Add osx_arm64 to the host test run matrix.
  • Ensure test-only behavior is enabled before loading the binary in the framework resolution test.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/installer/tests/HostActivation.Tests/FrameworkResolution/FrameworkResolution.cs Enable test-only behavior before the hostfxr binary is loaded to avoid macOS SIP reload crashes.
eng/pipelines/runtime.yml Remove old CoreCLR subset job, insert new CoreCLR_Libraries build for osx_arm64, and add osx_arm64 to the host test job.
Comments suppressed due to low confidence (2)

eng/pipelines/runtime.yml:208

  • The CoreCLR_Libraries job only builds clr+libs but the host tests require the host binaries and packs. Change this to -s clr+libs+host+packs (or whatever subset names include the host) to ensure the host executables are available for test runs.
            buildArgs: -s clr+libs -c $(_BuildConfig)

eng/pipelines/runtime.yml:1279

  • The indentation of this - osx_arm64 entry differs from the - windows_x86 line above, which may lead to YAML parsing errors or omit macOS ARM64 from the matrix. Align it to match the existing list indentation.
            - osx_arm64

@elinor-fung elinor-fung merged commit abc9652 into dotnet:main Jul 11, 2025
151 of 156 checks passed
@elinor-fung elinor-fung deleted the hostTests-osx-arm64 branch July 11, 2025 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants