Refactor emitInsSizeSVCalcDisp to more closely match the emitOutputSV checks #117430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #117288 where I noticed a lot of complexity in how
emitInsSizeSVhandled it's logic and some variance between it andemitOutputSV.There are a decent number of places where we have smaller size predictions and so allocate less bytes for the method. There are likewise a miniscule number of places where we actually emit smaller instructions based on the predictions:
Windows x64
Linux x64
However, there is a significant throughput improvement across the board due to the reduced complexity:
Windows x64
Linux x64
Windows x86