-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix BitConverter.ToUInt128 documentation inconsistency #117365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are more |
…xteen bytes" Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
…cies Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Fixed all "four bytes" documentation inconsistencies in BitConverter.cs. Updated ToUInt64 and ToDouble documentation to correctly state "eight bytes" (64-bit types). The previously fixed ToUInt128 and all remaining "four bytes" references for 32-bit types are now consistent. Changes committed in 6c874d8. |
The documentation for
BitConverter.ToUInt128(byte[] value, int startIndex)contained an inconsistency:Since
UInt128is a 128-bit integer, it requires 16 bytes (128 ÷ 8 = 16), not 4 bytes. This fix updates the summary to correctly state "sixteen bytes" to match the returns documentation and the actual implementation.Before:
After:
The change aligns with:
UInt128.Size = 16)ToInt128methodFixes #117364.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.