Skip to content

Conversation

@adamsitnik
Copy link
Member

fixes #117172

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses test flakiness in the AssemblyNameInfo tests by simplifying the test cases and assertions on the culture name conversion.

  • Removed platform‐dependent member data and conditional test attributes
  • Replaced the expected lower-cased culture value with a computed value using CultureInfo to normalize output across frameworks
Comments suppressed due to low confidence (2)

src/libraries/System.Reflection.Metadata/tests/Metadata/AssemblyNameInfoTests.cs:108

  • Ensure that the new inline test cases fully cover all scenarios previously addressed by the removed CultureNameGetLoweredByToAssemblyName_Arguments method. If there are additional edge cases to validate, consider adding them.
        }

src/libraries/System.Reflection.Metadata/tests/Metadata/AssemblyNameInfoTests.cs:122

  • Using CultureInfo(input).Name as the expected value makes the test more robust across platforms; please confirm that this behavior is consistent across all targeted frameworks.
            Assert.Equal(new CultureInfo(input).Name, assemblyNameInfo.ToAssemblyName().CultureName);

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@stephentoub stephentoub merged commit bc2e73a into dotnet:main Jul 1, 2025
85 of 90 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CultureNameGetLoweredByToAssemblyName test failed in CI

2 participants