Re-enable DynamicObjects test #116972
Open
Re-enable DynamicObjects test #116972
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-Tools-ILLink
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the DynamicObjects test and updates ExpectedWarning attributes to match the new Roslyn analyzer annotations.
- Updated ExpectedWarning attributes in DynamicObjects.cs to include both Tool.NativeAot and Tool.Analyzer flags with revised warning targets.
- Re-enabled the DynamicObjects test in ILLink.RoslynAnalyzer.Tests by removing the skip attribute.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs | Updated ExpectedWarning attribute parameters and comments to reflect new analyzer behavior. |
| src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/DataFlowTests.cs | Removed skip attribute to re-enable the DynamicObjects test. |
dotnet-policy-service
bot
added
the
linkable-framework
This was referenced Jun 24, 2025
jtschuster
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116218.
Re-enables the test and adds appropriate ExpectedWarnings for the Roslyn analyzer in response to the new annotations.