[Json] Fix error case in HalfConverter when dealing with large values #116884
+83
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error encountered when deserializing large Half values by adjusting the buffer length validations and adding comprehensive tests for various numeric types.
- Updated the HalfConverter to use a new constant for unescaped format length checks.
- Added new theory tests in NumberHandlingTests to validate error handling for large values across multiple numeric types.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Text.Json/tests/Common/NumberHandlingTests.cs | Added tests to verify proper exception throwing for oversized values during deserialization. |
| src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/HalfConverter.cs | Modified the logic in TryGetFloatingPointConstant to properly check the value length for both escaped and unescaped constants. |
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/HalfConverter.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
This was referenced Jun 21, 2025
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/HalfConverter.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jun 24, 2025
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run all |
|
No pipelines are associated with this pull request. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing
Half, sending a large value like123456789012345678901would result inArgumentException: Destination is too short.