[release/10.0-preview6] Record struct packing even when falling back to auto layout #116770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jeffschwMSFT
approved these changes
Jun 18, 2025
AaronRobinsonMSFT
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #116608 to release/10.0-preview6
/cc @jkoritzinsky
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
This issue was initially discovered by the AppCompat team.
Types that use the
StructLayout.Packfield can have incorrect layout. This can lead to anything fromSystem.OverflowExceptions (like in the reporting issue #116475) to invalid data marshalling between managed and unmanaged code (silent bad codegen-like failures).Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
#113454
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Added unit tests for this specific scenario
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low. Tests were added that pass with the behavior before the regressing PR and now.