Normalize immidates in arm32 add/sub #116711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM64 normalizes them like this and afair ARM32 takes immidates as unsigned so not having this forces using a register.
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
@a74nh, @amanasifkhalid, please review this community PR. |
a74nh
approved these changes
Jul 14, 2025
Contributor
a74nh
left a comment
a74nh
left a comment
There was a problem hiding this comment.
This looks good to me. Change is identical to the existing code in codegenarm64.cpp.
amanasifkhalid
approved these changes
Jul 14, 2025
Contributor
|
/ba-g test dead-lettered on unrelated platform |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM64 normalizes them like this and afair ARM32 takes immidates as unsigned so not having this forces using a register.