Skip to content

Revert "Revert "? true : false" removal (#70631)" #116528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 11, 2025

Contributes to #69156

This reverts commit a103efd.

Remove workaround for a JIT limitation that was resolved in #107499

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 11, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member

EgorBo commented Jun 11, 2025

@MihuBot

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@danmoseley
Copy link
Member

The JIT PR says "@stephentoub hit this problem when he was trying to showcase various jit optimizations on simple methods and had to rewrite them into if-else"... i wonder whether any of those need cleaning up (separately)

@xtqqczze
Copy link
Contributor Author

The JIT PR says "@stephentoub hit this problem when he was trying to showcase various jit optimizations on simple methods and had to rewrite them into if-else"... i wonder whether any of those need cleaning up (separately)

There is an open issue:

@tannergooding
Copy link
Member

We have quite a number of ? true : false throughout the src/libraries/* folder. It would be nice if we could get them all cleaned up at once rather than just touching them a couple files at a time.

CC. @stephentoub since you've generally done or driven larger refactorings like this in the past

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants