Skip to content

Implement SVE AddCarryWidening (Upper/Lower) #116429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 19, 2025
Merged

Implement SVE AddCarryWidening (Upper/Lower) #116429

merged 15 commits into from
Jun 19, 2025

Conversation

jacob-crawley
Copy link
Contributor

@a74nh @kunalspathak

Contributing towards #115479

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 9, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

This was referenced Jun 9, 2025
Open
Open
kunalspathak
kunalspathak reviewed Jun 9, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 9, 2025
View reviewed changes
kunalspathak
kunalspathak requested changes Jun 9, 2025
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

@kunalspathak kunalspathak mentioned this pull request Jun 9, 2025
Open
This was referenced Jun 17, 2025
Open
Open
Open
Open
Open
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Jun 18, 2025
Open
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak reviewed Jun 18, 2025
View reviewed changes
kunalspathak
kunalspathak approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jun 18, 2025
Open
Open
Open
Open
Open
This was referenced Jun 19, 2025
Open
Open
@kunalspathak
Copy link
Member

I am seeing superpmi replay failures related to loop alignment that I will investigate...


[16:53:12] ISSUE: <ASSERT> #86554 D:\a\_work\1\s\src\coreclr\jit\emit.cpp (6118) - Assertion failed 'markedLastLoop && markedCurrLoop' in 'NuGet.Configuration.PackageSourceProvider:ReadPackageSource(NuGet.Configuration.SourceItem,bool,NuGet.Configuration.ISettings):NuGet.Configuration.PackageSource' during 'Generate code' (IL size 122; hash 0xc751a93a; Tier1)

@kunalspathak
Copy link
Member

Opened #116836 for that.

@kunalspathak kunalspathak merged commit c86774f into dotnet:main Jun 19, 2025
155 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-crawley @kunalspathak